Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
The SQLite rewrite used seqNo directly for field_id, but appendField was not assigning seqNo when creating new fields during disc mapping. Some fields were appended with the default seqNo=0, which translated to field_id=-1 after the seqNo-1 conversion. Because (capture_id, field_id) is a primary key, the -1 rows collided, causing dropped/overwritten rows, shrinking field_record (missing fields) and triggering out-of-bounds errors in consumers like ld-analyse. JSON output was fine because it didn’t rely on field_id PKs.
Fix:
Ensure every appended field receives a contiguous seqNo (fields.size()+1) before being stored. Applied in both the TBC library (lddecodemetadata.cpp) and the json-converter copy (lddecodemetadata.cpp). This guarantees field_id stays 0..N-1 with no negatives or duplicates, so all fields persist in SQLite and downstream tools no longer see missing/invalid field numbers.