Course correct some broken tools, fix ld-ldf-reader and other minor fixes #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- Make it build again under prototypes
…with a fork or the repo
…df-reader requires switches. Updated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the ld-process-ac3 code from tools and into prototypes/ due to issue #971
Recreated the build environment for the ld-ac3-* tools under a local build/ directory and updated readme.md to explain build method.
Moved the ld-process-efm tool from tools and into prototypes/ (as a temporary holding position prior to removal) due to issue #959 - Fixed build environment so the tool can be compiled locally if required.
Fixed some minor formatting in some of the tools readme.md files to make Harry happy-Harry.
Refactored ld-ldf-reader into a proper tool - fixed structure, made it Qt, added logging, help, readme.md, etc. Added CI/CD testing for the tool into the overall repo testing - due to issue #972 (which is fixed by this PR).
There was also a small issue with the CI/CD using an unnecessary sym-link that caused minor testing issues - the sym-link has been removed.