ld-discmap omits end of disc #970
Description
Checklist
- ✅ I have searched the issues page for any duplicate issues open or closed and confirmed that this bug has not been reported before.
- ✅ I have tested the issue with the current build.
- ✅ I have attached log files, uploaded sample data, and commands used so that the issue can be easily reproduced by the developers.
Bug Description
Decode the first copy of side 1 of British Garden Birds. Discmap it and the resulting tbc is missing several hundred frames at the end. ld-analyse also gives a bunch of errors - Critical: LdDecodeMetaData::getField(): Requested field number 106220 out of bounds!
Steps to Reproduce
ld-decode --noEFM -p -t 4 --start 308 British_Garden_Birds_DD86-DS1_Side1_20200118_CAV_PAL_00001-53450.ldf set1_side1
ld-json-converter --input-json set1_side1.tbc.json --output-sqlite set1_side1.tbc.db
ld-process-vbi -n set1_side1.tbc
ld-discmap set1_side1.tbc map_set1_side1.tbc
Load map_set1_side1.tbc in ld-analyse and scrub to the end. Compare to how many frames are in un-mapped set1_side1.tbc
Expected Behaviour
Should be able to get to the end of the disc.
Actual Behaviour
Messages like below:
Critical: LdDecodeMetaData::getField(): Requested field number 106220 out of bounds!
Environment
- Decode version: HEAD
- Operating System: Ubuntu 24.04.3
- Hardware Used: Ryzen 9 7900X
Additional Information
My guess is it has something to do with how padding is added after the 340 invalid frames are removed. It also seems odd for that many frames to have incorrect phase sequence when the other RF captures of this disc do not.
Info: Processing input metadata for set1_side1.tbc
Info: Input TBC is a CAV disc using PAL
Info: Checking for lead in and out frames...
Info: Removing 1 frames marked as lead in/out
Info: Removing invalid frames by phase analysis...
Info: Removing 340 frames marked as invalid due to incorrect phase sequence
Info: Correcting frame numbers using sequence analysis...
Info: Sequence analysis corrected 20 frame numbers
Info: Searching for duplicate frames
Info: Removed 1 duplicate frames - disc map size now 53109 frames
Info: Verifying frame numbers are present for all frames in the disc map...
Info: Verification successful
Info: Sorting the disc map into numerical frame order...
Info: Sorting complete
Info: Looking for sequence gaps to pad in the disc map...
Info: Found 323 gaps representing 340 missing frames in the disc map
Info: Note: The disc map has been padded. This means that there were missing frames
Info: that will be represented by black frames in the output video.
Info: After padding the disc map contains 53449 frames
Info: Disc mapping process completed
Info: Writing output video and metadata information...
Info: Saving target video frames...
Info: Written frame 0 of 53449
Is it related to tbc-video-export?
lol no