Barcelona | OCT-2025-2 | Iheb Hamdi | Sprint 1 | Data-Groups #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsi88
suggested changes
Jan 16, 2026
| return listnumberOrdered[pos]; | ||
| } | ||
| else{ | ||
| return listnumberOrdered[pos-1]+0.5; |
There was a problem hiding this comment.
I don't think that's correct. What is a median of [1, 10] for example?
| // Then it should return an empty array | ||
| test.todo("given an empty array, it returns an empty array"); | ||
| test("Empty Arrat", () => { | ||
| const list=['a','a','a','b','b','c']; |
There was a problem hiding this comment.
But it's not an empty array as the test says.
Can you fix the test names pls?
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
Is it necessary to have multiple package.json files?
| @@ -1,9 +1,15 @@ | |||
| // Refactor the implementation of includes to use a for...of loop | |||
|
|
|||
| function includes(list, target) { | |||
| @@ -1,4 +1,22 @@ | |||
| function sum(elements) { | |||
| const elementNumbers = elements.filter((element) =>typeof element === 'number'); | |||
There was a problem hiding this comment.
Can you think how to simplify the function?
| // When passed to the sum function | ||
| // Then it should return that number | ||
| test("One number array", () => { | ||
| const list = [7, 42, 0, 9]; |
There was a problem hiding this comment.
There is more than one number. Can you pls ensure that the test names align with their content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.