Formaction on a button fix - #92
Merged
Merged
Conversation
dahlbyk
reviewed
Jan 2, 2024
dahlbyk
reviewed
Jan 2, 2024
dahlbyk
reviewed
Jan 2, 2024
haacked
force-pushed
the
haacked/formaction-fix
branch
from
January 5, 2024 21:47
b2402b4 to
2a469d7
Compare
When there's an input field, the formaction on a button doesn't work. Also add example with no formaction
When clicking a submit button with a formaction, we need to honor that formaction.
Co-authored-by: Keith Dahlby <dahlbyk@gmail.com>
Co-authored-by: Keith Dahlby <dahlbyk@gmail.com>
haacked
force-pushed
the
haacked/formaction-fix
branch
from
January 5, 2024 21:48
2a469d7 to
95b6ad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
The library has to do a bit of work to hook the form submit event, do its thing, and then recreate the submit event. However, we didn't factor in that the submit button might have a formaction attribute on it. Now we do.