#3457 increase max length of VAR* types#3464
Merged
grandinj merged 7 commits intoh2database:masterfrom Mar 30, 2022
Merged
Conversation
katzyn
reviewed
Mar 24, 2022
| * encoding data fields when storing rows. | ||
| */ | ||
| public static final int MAX_STRING_LENGTH = 1024 * 1024; | ||
| public static final int MAX_STRING_LENGTH = 1024 * 1024 * 1024; |
Contributor
There was a problem hiding this comment.
It should be 1_000_000_000 as specified in documentation.
1024^3 is actually larger than actual limit of java.lang.String since Java 9 (for strings with at least one character with code larger than 255).
to match the new documented value
which should speed it up
there is no way to test this without using up so much memory we'd probably get flagged for abusing CI
causes OOM on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.