ISSUE-3406 - Fixed ClassCastException on iterating result set for the FunctionMultiReturn.polar2CartesianArray call#3407
Merged
katzyn merged 3 commits intoh2database:masterfrom Jan 29, 2022
Conversation
… FunctionMultiReturn.polar2CartesianArray
katzyn
reviewed
Jan 28, 2022
| double a = rs.getDouble(2); | ||
| Object o = rs.getObject(3); | ||
| Object[] xy = (Object[]) o; | ||
| Object[] xy = (Object[])((JdbcArray) o).getArray(); |
Contributor
There was a problem hiding this comment.
JdbcArray is an internal class, it shouldn't be used here.
java.sql.Array or Double[] should be used instead.
Array o = rs.getArray(3);
// or
Double[] xy = rs.getObject(3, Double[].class);
Contributor
Author
There was a problem hiding this comment.
Hi @katzyn - I've updated the code based on your recommendations. Please let me know if you have any other recommendations. Thanks for your time.
Contributor
|
Thanks! |
Contributor
Author
|
Thanks for your time @katzyn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed class cast exception by casting to JdbcArray.