add getTemplate, add getter for PadTemplate, add PadTemplateTest #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you rebase (or reopen) against master? Got a merge conflict with your other PR. Thanks! |
Contributor
Author
|
yes, sure. |
Contributor
Author
|
should be fine to merge now |
Member
|
Thanks! Will merge. Not sure that I like the number to enum conversion, but can't think of a nicer way at the moment - will have a look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually i'm not sure about how to get template-name, direction, presence. there might be a better solution for this. maybe getting the data from the lowlevel structure to avoid this ugly casting stuff...
it works though.