-
-
Notifications
You must be signed in to change notification settings - Fork 72
Pipeline launch log error #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline launch log error #104
Conversation
|
Thanks for this! Agree with the need to not hide this, but disagree with this solution. I think we need to find a way to give the error back to the caller, but not sure of the best API to do that. Possibly something along the lines of Pipeline.launch(String description, List<String> errors);??? Could also be a chance to move this into Gst. Don't like the confusion with the same named method in Bin. So, possibly - Pipeline Gst.parseLaunch(String description, List<String> errors);
Bin Gst.parseBinFromDescription(String description, List<String> errors); |
|
yes, agree. would be better to give the error back to the caller. Pipeline.launch(String description, List<GError> errors);also agree to move it into Gst and aligning with gstreamer-function names |
|
Yes, |
|
Pipeline.initBus() is used after creating the pipeline. it is a private function with comments but without any functionality. |
|
when passing the error-list to launch(String...) with varargs it would need to look like this: Pipeline.launch(List<GError> errors, String... pipelineDecription);better to pass the error-list as first argument then? - that's weird too... |
|
I wouldn't assume it's a no-op too quickly! Am wondering why it's not in the constructor there though?! |
|
Or the new version could be |
|
initBus() is actually called in the contructor... so that's fine. |
|
Not in the one that takes an Short version - let's leave it for now! |
|
Thanks! Will pull this in but may rethink the API a little more before next release. |
|
should the launch() functions in Bin/Pipeline be removed? about the pipeline-constructor: question is why |
|
I will (probably) deprecate rather than remove the launch() methods for now, with aim to remove before 1.x. I need to look deeper at the |
|
yes. deprecating first... |
No description provided.