Skip to content

Conversation

@alexlamsl
Copy link
Contributor

@XhmikosR PTAL

@XhmikosR
Copy link
Member

BTW, I removed you many months ago from the npm users from grunt-contrib-uglify, because you hadn't enabled 2FA. If you have enabled it, let me know and I will add you back.

@alexlamsl
Copy link
Contributor Author

I have 2FA for npm working now I think, i.e. every time I do npm login or npm publish I get prompted for "OTP token".

@XhmikosR
Copy link
Member

@alexlamsl can you rebase this and make sure package-lock.json doesn't have any unneeded stuff?

I added you back to npm BTW.

@alexlamsl
Copy link
Contributor Author

Sorry for the delay - was in a call just now.

I've made sure package-lock.json only contains version string change.

@XhmikosR
Copy link
Member

Let's wait for CI and then merge. Then create the GH release, which creates the tag and then npm publish.

@alexlamsl alexlamsl merged commit f65dbb9 into master Mar 21, 2019
@alexlamsl alexlamsl deleted the release-v4.0.1 branch March 21, 2019 18:45
@alexlamsl
Copy link
Contributor Author

@XhmikosR heh, you beat me to tag and publish by mere seconds 👻

@XhmikosR
Copy link
Member

haha, I wasn't sure if you were going to do it yourself :P

@alexlamsl
Copy link
Contributor Author

alexlamsl commented Mar 21, 2019

AppVeyor build on master got stuck in the queue, so I was anxiously waiting for it to pass.

Thanks for the help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants