s2a: Improve S2AStubTest clarity and performance#12618
Merged
kannanjgithub merged 1 commit intogrpc:masterfrom Feb 5, 2026
Merged
s2a: Improve S2AStubTest clarity and performance#12618kannanjgithub merged 1 commit intogrpc:masterfrom
kannanjgithub merged 1 commit intogrpc:masterfrom
Conversation
Rename send_receiveOkStatus to test successful response handling using FakeWriter instead of timing out with a real connection. Add send_withUnavailableService_throwsDeadlineExceeded test with a 1-second deadline to verify timeout behavior without the 20-second wait.
|
|
kannanjgithub
approved these changes
Feb 5, 2026
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Changes look good.
kannanjgithub
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors S2AStubTest to address issues in #12581:
Rename
send_receiveOkStatusto test successful responses using FakeWriterAdd
send_withUnavailableService_throwsDeadlineExceededwith 1-second deadline for timeout testingas is
Reduces test execution time from 20 seconds to 1 second while clarifying test intent.