update project dependencies to work with python 3.14#38
Merged
Conversation
stefan-balke
reviewed
May 6, 2026
stefan-balke
left a comment
stefan-balke
left a comment
Contributor
There was a problem hiding this comment.
No breaking changes. LGTM
Contributor
|
|
Contributor
okay, this is already fixed in this PR |
Closed
milahu
reviewed
May 9, 2026
Comment on lines
+235
to
+236
| anchor_indices = np.flatnonzero((a[0] == warping_path[0, :]) & (a[1] == warping_path[1, :])) | ||
| indices[k] = anchor_indices[0] |
There was a problem hiding this comment.
add this check?
anchor_indices = np.flatnonzero((a[0] == warping_path[0, :]) & (a[1] == warping_path[1, :]))
if anchor_indices.size == 0:
raise ValueError(f"Anchor {a.tolist()} not found in warping path")
indices[k] = anchor_indices[0]or probably that case would raise IndexError at anchor_indices[0]
milahu
reviewed
May 9, 2026
| @@ -228,11 +228,12 @@ def find_anchor_indices_in_warping_path(warping_path: np.ndarray, | |||
| indices : np.ndarray [shape=(2, M)] | |||
There was a problem hiding this comment.
chatGPT says the return type is wrong
- indices : np.ndarray [shape=(2, M)]
+ indices : np.ndarray [shape=(M,)]
Contributor
There was a problem hiding this comment.
Yes, true. Double-checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.