fix(core): ViewContainerRef.indexOf doesn't throw error when empty (angular#13220)

Dzmitry Shylovich · mhevery · commit 41b8d95fa7df · 2017-02-02T16:02:53.000-08:00
PR Close angular#13220
diff --git a/modules/@angular/core/src/linker/view_container_ref.ts b/modules/@angular/core/src/linker/view_container_ref.ts
@@ -186,7 +186,8 @@ export class ViewContainerRef_ implements ViewContainerRef {
   }
 
   indexOf(viewRef: ViewRef): number {
-    return this._element.nestedViews.indexOf((<ViewRef_<any>>viewRef).internalView);
+    return this.length ? this._element.nestedViews.indexOf((<ViewRef_<any>>viewRef).internalView) :
+                         -1;
   }
 
   /** @internal */
@@ -213,7 +214,7 @@ export class ViewContainerRef_ implements ViewContainerRef {
     return wtfLeave(s, view.ref);
   }
 
-  clear() {
+  clear(): void {
     for (let i = this.length - 1; i >= 0; i--) {
       this.remove(i);
     }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,8 @@ export class ViewContainerRef_ implements ViewContainerRef {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`indexOf(viewRef: ViewRef): number {`
`189`		`- return this._element.nestedViews.indexOf((<ViewRef_<any>>viewRef).internalView);`
	`189`	`+ return this.length ? this._element.nestedViews.indexOf((<ViewRef_<any>>viewRef).internalView) :`
	`190`	`+ -1;`
`190`	`191`	`}`
`191`	`192`
`192`	`193`	`/** @internal */`
`@@ -213,7 +214,7 @@ export class ViewContainerRef_ implements ViewContainerRef {`
`213`	`214`	`return wtfLeave(s, view.ref);`
`214`	`215`	`}`
`215`	`216`
`216`		`- clear() {`
	`217`	`+ clear(): void {`
`217`	`218`	`for (let i = this.length - 1; i >= 0; i--) {`
`218`	`219`	`this.remove(i);`
`219`	`220`	`}`