Skip to content

Https config for issue #44#48

Merged
greengerong merged 3 commits intogreengerong:masterfrom
kgujral:master
May 29, 2018
Merged

Https config for issue #44#48
greengerong merged 3 commits intogreengerong:masterfrom
kgujral:master

Conversation

@kgujral
Copy link

@kgujral kgujral commented May 11, 2018

No description provided.

@kgujral
Copy link
Author

kgujral commented May 11, 2018

I have created this new PR. Finally all checks have passed :)

@kgujral
Copy link
Author

kgujral commented May 11, 2018

Everything looks good. Please merge this one whenever you have the time.

@thoop
Copy link
Contributor

thoop commented May 14, 2018

@greengerong can you merge this? Thanks!

@kgujral
Copy link
Author

kgujral commented May 15, 2018

Hi, I don't think I have the access to merge the PR. You'll have to do it

@thoop
Copy link
Contributor

thoop commented May 15, 2018

Sorry, I was tagging @greengerong so that he would get a notification and see this. @greengerong can you merge this? He's the one that has merge access.

@kgujral
Copy link
Author

kgujral commented May 16, 2018

Ohh sorry I misread it! My Bad

@greengerong greengerong merged commit 7db72b9 into greengerong:master May 29, 2018
@greengerong
Copy link
Owner

Thanks

@thoop
Copy link
Contributor

thoop commented May 29, 2018

@greengerong Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants