Skip to content

Https config for issue #44#45

Closed
kgujral wants to merge 2 commits intogreengerong:masterfrom
kgujral:HTTPS_CONFIG
Closed

Https config for issue #44#45
kgujral wants to merge 2 commits intogreengerong:masterfrom
kgujral:HTTPS_CONFIG

Conversation

@kgujral
Copy link

@kgujral kgujral commented Apr 28, 2018

No description provided.

@thoop
Copy link
Contributor

thoop commented May 11, 2018

Thanks @kgujral! Looks great. I'm not sure why the CI failed though. Did you change anything there? Can you try running that again? Seems like it was just your readme change that caused it to fail.

@kgujral
Copy link
Author

kgujral commented May 11, 2018

No I did not change anything that might make the CI fail. I read the CI logs seems like an issue with the CI rather than the code itself.

The JAVA_HOME environment variable is not defined correctly
This environment variable is needed to run this program
NB: JAVA_HOME should point to a JDK not a JRE
The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed 3 times.

@thoop
Copy link
Contributor

thoop commented May 11, 2018

@greengerong any idea why this might have failed? Can you force a retry? And if it looks good, can you merge this PR? It adds a nice protocol config option :)

@kgujral kgujral closed this May 11, 2018
@kgujral
Copy link
Author

kgujral commented May 11, 2018

Created new PR #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants