Support middlewares for subscriptions#221
Merged
Cito merged 10 commits intographql-python:mainfrom Jul 7, 2024
Merged
Conversation
11 tasks
Contributor
Author
|
@Cito can you aprove the workflows? |
Member
|
Thanks, will review this tomorrow. |
Cito
requested changes
Jul 7, 2024
Member
Cito
left a comment
Cito
left a comment
There was a problem hiding this comment.
Looks good to me, thank you.
Just minor stylistic changes for consistency, see suggestions.
Co-authored-by: Christoph Zwerschke <cito@online.de>
Co-authored-by: Christoph Zwerschke <cito@online.de>
Co-authored-by: Christoph Zwerschke <cito@online.de>
Cito
requested changes
Jul 7, 2024
Member
Cito
left a comment
Cito
left a comment
There was a problem hiding this comment.
The dummy resolver can be removed.
Co-authored-by: Christoph Zwerschke <cito@online.de>
Cito
approved these changes
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #188
I am not sure if this requires more tests because AFAIR its basically the same as async execution.
Please let me know it needs more @Cito