Use Graphene DataLoader in graphene>=3.1.1#360
Merged
erikwrede merged 5 commits intographql-python:masterfrom Sep 8, 2022
Merged
Use Graphene DataLoader in graphene>=3.1.1#360erikwrede merged 5 commits intographql-python:masterfrom
erikwrede merged 5 commits intographql-python:masterfrom
Conversation
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 9 9
Lines 773 773
=======================================
Hits 745 745
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flipbit03
previously approved these changes
Sep 6, 2022
Contributor
flipbit03
left a comment
flipbit03
left a comment
There was a problem hiding this comment.
LGTM! 🔥 Now we need to wait for the merge in graphene to move forward with this. Thank you!
! 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issues described in graphql-python/graphene#1459