[Regression Fix] Call custom resolve functions if provided #241
Merged
jnak merged 2 commits intographql-python:masterfrom Aug 14, 2019
Merged
[Regression Fix] Call custom resolve functions if provided #241jnak merged 2 commits intographql-python:masterfrom
jnak merged 2 commits intographql-python:masterfrom
Conversation
add documentation
Nabellaleen
approved these changes
Aug 14, 2019
Collaborator
Nabellaleen
left a comment
Nabellaleen
left a comment
There was a problem hiding this comment.
Good for me ! Sorry for the delay :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #234. The regression was introduced in 2.2.1.
Custom
resolve_<field_name>functions were no longer call for fields auto-generated bySQLAlchemyObjectType. The issue was caused by a soon-to-be-documented feature that allows users to rename auto-generated fields (akaORMField.model_attr).