Skip to content

bug fix 393 - #399

Merged
oliemansm merged 1 commit into
graphql-java-kickstart:masterfrom
bgoodin:master
Jan 22, 2022
Merged

oliemansm merged 1 commit into
graphql-java-kickstart:masterfrom
bgoodin:master

Conversation

@bgoodin

@bgoodin bgoodin commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

A possible change to the GraphQLSingleInvocationInput that will help support the new context in alignment with graphql-java-tools.

See:
graphql-java-kickstart/graphql-java-tools#566

@bgoodin

bgoodin commented Dec 10, 2021 •

Copy link
Copy Markdown
Contributor Author

I'm actually not sure that this is addressing the 393 bug anymore. What this is attempting to do is allow for the ability to migrate off of the deprecated DataFetchingEnvironment.getContext() method and use the DataFetchingEnvironment.getGraphQlContext() while still having access to the "custom" context. It's a bit inception-like because it is a context in a context. Perhaps there is a better way to go about this. I'm open to a better way.

This allows me to do something like the following:

final CustomGraphQLContext customGraphQLContext = dataFetchingEnvironment
.getGraphQlContext()
.get(CustomGraphQLContext.class);

@oliemansm

Copy link
Copy Markdown
Member

@bgoodin Inception like indeed! ;) I'll merge it as a starting point for further enhancements.

@oliemansm
oliemansm merged commit cea4114 into graphql-java-kickstart:master Jan 22, 2022
@oliemansm oliemansm added this to the 12.1.0 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants