Repository navigation
Conversation
|
Thank you so much for the contribution! I have an alternative suggestion and want to test it with you and see if it will solve your problem with the schema builder graphql-java-servlet is shipping with. Instead of breaking up one class into a hierarchy, how about having a |
|
If I understand correctly, you want to remove |
|
Precisely. Do you think this will work well for your case?
…On Thu, Jan 12, 2017 at 11:02 PM apottere ***@***.***> wrote:
If I understand correctly, you want to remove queryProviders,
mutationProviders, and typesProviders from GraphQLServlet and instead
have that take a schemaProvider, one of which could implement the
original functionality of taking the other providers and building the
schema?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxGrTYzqSVxQ106ifHYieXQst0t6Pks5rRk6CgaJpZM4Lg6f2>
.
|
|
I think it would work, I'll open another PR with a prototype of that and you can see which fits better. |
|
closing in favor of #15 |
In order to get a working servlet in our application with (https://github.com/Distelli/graphql-apigen), we needed a way to forego the type/mutation/query providers and provide a schema directly to the servlet.
I extracted all of the servlet logic to an abstract parent that
GraphQLServletnow extends, in order to keepGraphQLServletexactly the same as it was before but also allow us to subclassAbstractGraphQLServletfor our purposes.I can add a simple implementation of the abstract parent to this project as well, if that's desired.