You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
When dispatchPredicate condition evaluates to false, shouldDispatch should return false #138
Is it expected that we always set an explicit overall dispatch predicate (different from DISPATCH_ALWAYS) that would serve as a backup? Currently I have to set it to either DISPATCH_NEVER or some other reasonable default that would eventually be applied so that the individual data loader dispatch predicates get a chance to be applied.
I think you are right - the current code does a fall back to an overall DispatchPredicate if it never returns true but looking at it now on reflection, if there is a specific DispatchPredicate registered for a DataLoader it should take precedence and be the final answer. After all it was specifically set on that data loader.
Activity
bbakerman commentedon Apr 13, 2024
I think you are right - the current code does a fall back to an overall
DispatchPredicateif it never returns true but looking at it now on reflection, if there is a specificDispatchPredicateregistered for a DataLoader it should take precedence and be the final answer. After all it was specifically set on that data loader.I am going to change this.
bbakerman commentedon Apr 13, 2024
This is now fixed
srinivasankavitha commentedon Apr 14, 2024
Great, thank you!
Dispatch loaders registered without a predicate (Netflix#2358)