Added DataFetcherFactory support#735
Merged
bbakerman merged 3 commits intoOct 2, 2017
Merged
Conversation
Adds a level of indirection into the data fetchers which are specified at schema def time but needed "wired" at query execution time
andimarek
requested changes
Oct 1, 2017
| * | ||
| * @return a data fetcher factory that always returns the provided data fetcher | ||
| */ | ||
| static <DF> DataFetcherFactory<DF> useDataFetcher(DataFetcher<DF> dataFetcher) { |
Member
There was a problem hiding this comment.
not really sure about that one: Can we the static factory method to somewhere else?
| public GraphQLFieldDefinition(String name, String description, GraphQLOutputType type, DataFetcherFactory dataFetcherFactory, List<GraphQLArgument> arguments, String deprecationReason, FieldDefinition definition) { | ||
| assertValidName(name); | ||
| assertNotNull(dataFetcher, "dataFetcher can't be null"); | ||
| assertNotNull(dataFetcherFactory, "dataFetcherFactory can't be null"); |
Member
There was a problem hiding this comment.
this is confusing I think: until know we only have DataFetcher ... no we say DataFetcherFactory can't be null: maybe something like 'you have to provide a DataFetcher (or DataFetcherFactory)' ?
| * | ||
| * @return a data fetcher | ||
| */ | ||
| DataFetcher<T> get(GraphQLFieldDefinition fieldDefinition); |
Member
There was a problem hiding this comment.
I think it is safer for the future provide an ....Environment Object containing the fieldDefitinion, but also the parent "container".
…factory-support # Conflicts: # src/main/java/graphql/schema/GraphQLFieldDefinition.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a level of indirection into the data fetchers which are specified at
schema def time but needed "wired" at query execution time
see #734