Repository navigation
Conversation
…s-complete-futures # Conflicts: # src/main/java/graphql/execution/batched/UnbatchedDataFetcher.java
bbakerman
commented
Sep 6, 2017
| @@ -201,6 +202,52 @@ private CompletableFuture<List<ExecutionNode>> resolveField(ExecutionContext exe | |||
|
|
|||
| } | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
Mostly moved this up in the file so its near where it gets called and tweaked the DF fetching to use the Async code
Member
Author
|
Ok so your original PR fixed this @andimarek but I think there is some refactor value in this one as well reagarding Async and using it commonly in a few places |
andimarek
requested changes
Sep 6, 2017
andimarek
left a comment
Member
There was a problem hiding this comment.
looks good except the now duplicate methode in Async
| * | ||
| * @return a CompletableFuture of List T | ||
| */ | ||
| public static <T> CompletableFuture<List<T>> combineAllOf(List<CompletableFuture<T>> listOfFutures) { |
Member
There was a problem hiding this comment.
this is not needed: please use each(List<CompletableFuture<U>> futures)
| * | ||
| * @return a CompletableFuture | ||
| */ | ||
| public static <T> CompletableFuture<T> toCompletableFuture(T t) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #672 and #683