Skip to content

fix handling of non batched data fetchers returning CompletableFuture - #695

Merged
bbakerman merged 1 commit into
masterfrom
batched-completable-fix
Sep 6, 2017
Merged

bbakerman merged 1 commit into
masterfrom
batched-completable-fix

Conversation

@andimarek

Copy link
Copy Markdown
Member

fix handling of non batched data fetchers returning CompletableFuture

fix handling of non batched data fetchers returning CompletableFuture
@andimarek
andimarek requested a review from bbakerman September 6, 2017 09:11
@bbakerman bbakerman added this to the 5.0 milestone Sep 6, 2017
@bbakerman bbakerman added the bug label Sep 6, 2017
@bbakerman
bbakerman merged commit 5b5a30f into master Sep 6, 2017

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your tests and I like my refactoring
perhaps we merge your changes first and I rejig mine to exclude my tests but include my refactors

@andimarek andimarek changed the title fix batched execution fix handling of non batched data fetchers returning CompletableFuture Sep 8, 2017
@andimarek andimarek modified the milestones: 4.2, 5.0 Sep 11, 2017
andimarek added a commit that referenced this pull request Sep 11, 2017
fix handling of non batched data fetchers returning CompletableFuture

(cherry picked from commit 5b5a30f)
@andimarek
andimarek deleted the batched-completable-fix branch September 11, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants