Skip to content

Fixes BatchedExecutionStrategy to work with CompletionStages - #694

Closed
arlampin wants to merge 1 commit into
graphql-java:masterfrom
arlampin:batched-async-fixes
Closed

arlampin wants to merge 1 commit into
graphql-java:masterfrom
arlampin:batched-async-fixes

Conversation

@arlampin

@arlampin arlampin commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

Fixes #672 & #683

BatchedExecutionStrategy should now supports DataFetchers returning both List<CompletionStage<Object>> and CompletionStage<List<Object>>. Plain List<Object> is still obviously supported.

I integrated the test case from #672 by @drewolson into this PR.

@bbakerman

Copy link
Copy Markdown
Member

This you for submitting this PR. The project appreciates it. It looks like 3 of us decide to fix this problem in very similar ways.

#695

#696

#694

I have merged 695 and hence we dont need this extra one.

We do appreciate the PR however

@bbakerman bbakerman closed this Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants