Skip to content

Allow any Iterable as GraphQLList value for BatchedExecutionStrategy - #676

Closed
arlampin wants to merge 2 commits into
graphql-java:masterfrom
arlampin:master
Closed

arlampin wants to merge 2 commits into
graphql-java:masterfrom
arlampin:master

Conversation

@arlampin

@arlampin arlampin commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

Fixes #667

@He-Pin

He-Pin commented Sep 1, 2017

Copy link
Copy Markdown

And Array:)

@bbakerman

Copy link
Copy Markdown
Member

#679 will allow arrays returned and tweaks the error messages a little better

@arlampin

arlampin commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

That's another issue, I was talking about BatchedExecutionStrategy.handleList(), not overall BatchedDataFetcher return type.

@arlampin

arlampin commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

I updated PR to use the exact same logic as regular ExecutionStrategy, which supports arrays (and also primitive arrays after #681 has been merged)

@bbakerman

bbakerman commented Sep 4, 2017 •

Copy link
Copy Markdown
Member

I have updated #679 with the contents of this PR and its extra test

I think this one can be closed as the other one contains it (in practice) plus some more code

@bbakerman bbakerman closed this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants