Skip to content

Pr 600 michaelplavnik schema printer improvments#648

Merged
bbakerman merged 6 commits into
graphql-java:masterfrom
bbakerman:pr-600-michaelplavnik-schema-printer-improvments
Aug 28, 2017
Merged

Pr 600 michaelplavnik schema printer improvments#648
bbakerman merged 6 commits into
graphql-java:masterfrom
bbakerman:pr-600-michaelplavnik-schema-printer-improvments

Conversation

@bbakerman

Copy link
Copy Markdown
Member

This fixes * imports on https://github.com/graphql-java/graphql-java/pull/600/files and otherwise accepts the PR.

mp81682 and others added 6 commits August 4, 2017 08:33
Documentaiton build on windows failed as '-' character was not from cp1252 code page (first 127 codes).
1. graphql-spqr generates schema out of GraphQL types subclasess and changes in this commit handle it correctly.

2. Empty discriptions are not printed out.
…vnik-schema-printer-improvments

# Conflicts:
#	src/main/java/graphql/schema/idl/SchemaPrinter.java
@bbakerman bbakerman added this to the 4.0.0 milestone Aug 28, 2017
@bbakerman bbakerman merged commit 465271b into graphql-java:master Aug 28, 2017
huangd0ng pushed a commit to dayuwuxian/graphql-java that referenced this pull request Aug 29, 2017
* Allow subclasses of the types to be printed.

* Replace '-' character with one from cp1252

Documentaiton build on windows failed as '-' character was not from cp1252 code page (first 127 codes).

* Support instances of classes derived from schema classes

1. graphql-spqr generates schema out of GraphQL types subclasess and changes in this commit handle it correctly.

2. Empty discriptions are not printed out.

* Fixed * imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants