SchemaPrinter improvements#600
Closed
michaelplavnik wants to merge 3 commits into
Closed
Conversation
Documentaiton build on windows failed as '-' character was not from cp1252 code page (first 127 codes).
1. graphql-spqr generates schema out of GraphQL types subclasess and changes in this commit handle it correctly. 2. Empty discriptions are not printed out.
Member
|
@michaelplavnik thank you very much for this PR. One suggestion: Could you split it up and make different PRs out of it? Because some aspects we could merge right away (the documentation fix for example) and others we need to talk about a bit. It would really help to stay focused. |
Member
|
Note: The documentation fix is now done: see #636 |
Member
|
Now done via another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow subclasses of the GraphQL schema types to be printed.
For example, graphql-spqr generates schema out of GraphQL types subclasses and changes in this commit allow to print such schema correctly.
Replace '-' character in documentation with one from cp1252 code page.
Documentation build on windows failed as '-' character was not from cp1252 code page.
Beautify printed output by ignoring empty descriptions.