Refactor GraphQL#execute implementation#509
Merged
Merged
Conversation
bbakerman
requested changes
Jun 17, 2017
bbakerman
left a comment
bbakerman
left a comment
Member
There was a problem hiding this comment.
I am happy to accept this one with the method rename
(which is a minor thing to be honest)
Member
There was a problem hiding this comment.
Can we call this getDocument please
nit: no need for public modifier on private class
…entation lifecycles
tklovett
force-pushed
the
graphql-execute-refactor
branch
from
0c0fdb0 to
0b85a3b
Compare
tklovett
commented
Jun 19, 2017
| Execution execution = new Execution(queryStrategy, mutationStrategy, subscriptionStrategy, instrumentation); | ||
| ExecutionResult result = execution.execute(executionId, graphQLSchema, context, root, document, operationName, variables); | ||
| ExecutionId executionId = idProvider.provide(query, operationName, context); | ||
| return execution.execute(document, graphQLSchema, executionId, executionInput); |
Contributor
Author
There was a problem hiding this comment.
This @Internal API change (and corresponding changes in Execution and ExecutionTest) is new in this amended commit and was not previously reviewed.
tklovett
commented
Jun 19, 2017
| final Object context = executionInput.getContext(); | ||
| final Object root = executionInput.getRoot(); | ||
| final String operationName = executionInput.getOperationName(); | ||
| final Map<String, Object> variables = executionInput.getVariables(); |
Contributor
Author
There was a problem hiding this comment.
These can be inlined if you like, but will then cause merge conflicts with #508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here was to
I believe that I have not significantly changed when or under what conditions the
onEndinstrumentation methods are called. Its worth noting that theonEndmethods are not guaranteed to be called in all possible error scenarios.