Repository navigation
Coercing exception handling - #487
Merged
Merged
Conversation
handle serialize exception in ExecutionStrategy
enum serialization exceptions are handled correctly
This was referenced Jun 5, 2017
bbakerman
approved these changes
Jun 8, 2017
bbakerman
left a comment
Member
There was a problem hiding this comment.
Its a nitpick on the parameter ordering but otherwise looks good
| return result; | ||
| } | ||
|
|
||
| protected ExecutionResult completeValueForEnum(GraphQLEnumType enumType, ExecutionStrategyParameters parameters, Object result) { |
Member
There was a problem hiding this comment.
Can we make the signature
protected ExecutionResult completeValueForEnum(GraphQLEnumType enumType, ExecutionContext
context, ExecutionStrategyParameters parameters, Object result) {
That way its sympathetic to the other methods that have ExecutionContext
context, ExecutionStrategyParameters parameters as parameters
In fact you could argue for consistency they should be the 1st two parameters (since this is a breaking change)
Member
|
Since it was only a nitpick I would rather get this in an do a 2nd PR to fix up the nitpick |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two different GraphQLException for Coercing serialize/parseValue.
It handles enum values serialization and scalars serialization correctly by catching the exception, adding an Error and setting the value to null.
It is a breaking change, because some protected methods ins
ExecutionStrategyare changed including the logic (not sure if the logic changes classifie as bug fix or not)