Skip to content

remove unused extensions field from ExecutionResult(Impl) - #484

Merged
bbakerman merged 1 commit into
masterfrom
remove-extensions
Jun 4, 2017
Merged

bbakerman merged 1 commit into
masterfrom
remove-extensions

Conversation

@andimarek

Copy link
Copy Markdown
Member

As discussed here: #480 (comment)

@andimarek andimarek added the breaking change requires a new major version to be relased label Jun 3, 2017
@andimarek

Copy link
Copy Markdown
Member Author

This is a breaking change because we removed the field completely.

@andimarek andimarek added this to the 4.0.0 milestone Jun 3, 2017

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should remove it since its the "engines" responsibility to put it there

@bbakerman
bbakerman merged commit e284b7e into master Jun 4, 2017
@andimarek
andimarek deleted the remove-extensions branch June 5, 2017 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change requires a new major version to be relased

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants