Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (2 classes)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscription { ticks { name } }with default settings and an asyncTick.namefetcher, two events resolving on two pool threads, subscriber counting callers insideonNext:CompletionStageSubscriberbacks the default (unordered) subscription publisher and callsdownstreamSubscriber.onNextfromwhenNextFinishedon whichever thread completes each event's promise, outside its lock, so events resolving on different threads reach the subscriber at the same time (reactive streams rule 1.3).onErrorcan overlap an in-progressonNextthe same way, and a value that was already completing can still be delivered afteronError. the TCK runs here skip the stochastic spec103 check and complete every promise on a single-thread executor, andCapturingSubscribersynchronizes its ownonNext, so the tests never hit it.onNextandonErrornow reach the downstream subscriber under the existing lock, andonNextis skipped once the subscriber is terminal.CompletionStageOrderedSubscriberalready deliveredonNextunder that lock; its drain loop now also stops once terminal. the two newCompletionStageSubscriberTestcases run against both subscribers and fail before the change (unordered: both, ordered: theonErrorone).