Repository navigation
Remove experimental schema diffing implementation - #4559
Merged
Merged
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (150 classes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the experimental graph-edit-distance schema diffing implementation, including its graph model, mapping algorithm, edit analysis, and all three associated Spock test classes. Also remove the dependent experimental
CyclicSchemaAnalyzerutility and its tests.Remove seven Guava allowlist entries and the single-element
FpKit.concat(List, T)overload whose only callers were in the deleted implementation. Extend the existingassertFalsetest to verify acceptance offalseas well as rejection oftrue, replacing incidental coverage previously supplied by the removed tests. The existinggraphql.schema.diffAPI and its tests remain available, along with shared schema fixtures.This removes the
graphql.schema.diffing/graphql.schema.diffing.anatypes andgraphql.util.CyclicSchemaAnalyzer; callers using those experimental/internal APIs will need to stop using them.Validation:
./gradlew assemble test testng check javadoc jacocoTestReportpassed.SchemaDiffand the list-to-list helper.025533a39: Java 17/21/25 tests and TestNG, build checks, Javadoc, jcstress, file validation, and the per-class coverage gate.The lower test count is expected from deleting the four obsolete test classes. The generated master coverage baseline is retained for comparison and will be regenerated by the master workflow after merge.