Skip to content

Remove experimental schema diffing implementation - #4559

Merged
andimarek merged 2 commits into
masterfrom
codex/remove-experimental-schema-diffing
Nov 13, 2026
Merged

andimarek merged 2 commits into
masterfrom
codex/remove-experimental-schema-diffing

Conversation

@andimarek

@andimarek andimarek commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Remove the experimental graph-edit-distance schema diffing implementation, including its graph model, mapping algorithm, edit analysis, and all three associated Spock test classes. Also remove the dependent experimental CyclicSchemaAnalyzer utility and its tests.

Remove seven Guava allowlist entries and the single-element FpKit.concat(List, T) overload whose only callers were in the deleted implementation. Extend the existing assertFalse test to verify acceptance of false as well as rejection of true, replacing incidental coverage previously supplied by the removed tests. The existing graphql.schema.diff API and its tests remain available, along with shared schema fixtures.

This removes the graphql.schema.diffing / graphql.schema.diffing.ana types and graphql.util.CyclicSchemaAnalyzer; callers using those experimental/internal APIs will need to stop using them.

Validation:

  • Java 25: ./gradlew assemble test testng check javadoc jacocoTestReport passed.
  • All 844 remaining classes pass the unchanged per-class coverage baseline.
  • Verified the published JAR contains neither removed API nor the unused single-element helper, and retains SchemaDiff and the list-to-list helper.
  • All 10 CI checks passed on 025533a39: Java 17/21/25 tests and TestNG, build checks, Javadoc, jcstress, file validation, and the per-class coverage gate.

The lower test count is expected from deleting the four obsolete test classes. The generated master coverage baseline is retained for comparison and will be regenerated by the master workflow after merge.

@andimarek andimarek added this to the 27 milestone Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 17 6369 (-228 🔴) 6313 (-228 🔴) 0 (±0) 0 (±0) 56 (±0)
Java 21 6369 (-228 🔴) 6313 (-228 🔴) 0 (±0) 0 (±0) 56 (±0)
Java 25 6369 (-228 🔴) 6313 (-228 🔴) 0 (±0) 0 (±0) 56 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 19139 (-684 🔴) 18971 (-684 🔴) 0 (±0) 0 (±0) 168 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 27000 2718 90.9% -0.2% 🔴
Branches 7733 1179 86.8% +0.7% 🟢
Methods 7450 1102 87.1% -0.5% 🔴

Changed Class Coverage (150 classes)

Class Line Branch Method
g.s.d.a.EditOperationAnalysisResult removed removed removed
g.s.d.a.EditOperationAnalyzer removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveAddition
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveArgumentAddition
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveArgumentDeletion
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveArgumentRename
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveArgumentValueModification
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveDeletion
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveDirectiveArgumentLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveDirectiveLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveEnumLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveEnumValueLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveInputObjectFieldLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveInputObjectLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveInterfaceFieldArgumentLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveInterfaceFieldLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveInterfaceLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveObjectFieldArgumentLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveObjectFieldLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveObjectLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveRenamed
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveScalarLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveSchemaLocation
removed removed removed
g.s.d.a.SchemaDifference
$AppliedDirectiveUnionLocation
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveAddition
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveArgumentAddition
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveArgumentDefaultValueModification
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveArgumentDeletion
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveArgumentRename
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveArgumentTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveDeletion
removed removed removed
g.s.d.a.SchemaDifference
$DirectiveModification
removed removed removed
g.s.d.a.SchemaDifference
$EnumAddition
removed removed removed
g.s.d.a.SchemaDifference
$EnumDeletion
removed removed removed
g.s.d.a.SchemaDifference
$EnumModification
removed removed removed
g.s.d.a.SchemaDifference
$EnumValueAddition
removed removed removed
g.s.d.a.SchemaDifference
$EnumValueDeletion
removed removed removed
g.s.d.a.SchemaDifference
$EnumValueRenamed
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectAddition
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectFieldAddition
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectFieldDefaultValueModification
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectFieldDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectFieldRename
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectFieldTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$InputObjectModification
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceAddition
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldAddition
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldArgumentAddition
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldArgumentDefaultValueModification
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldArgumentDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldArgumentRename
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldArgumentTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldRename
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceFieldTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceInterfaceImplementationAddition
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceInterfaceImplementationDeletion
removed removed removed
g.s.d.a.SchemaDifference
$InterfaceModification
removed removed removed
g.s.d.a.SchemaDifference
$ObjectAddition
removed removed removed
g.s.d.a.SchemaDifference
$ObjectDeletion
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldAddition
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldArgumentAddition
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldArgumentDefaultValueModification
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldArgumentDeletion
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldArgumentRename
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldArgumentTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldDeletion
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldRename
removed removed removed
g.s.d.a.SchemaDifference
$ObjectFieldTypeModification
removed removed removed
g.s.d.a.SchemaDifference
$ObjectInterfaceImplementationAddition
removed removed removed
g.s.d.a.SchemaDifference
$ObjectInterfaceImplementationDeletion
removed removed removed
g.s.d.a.SchemaDifference
$ObjectModification
removed removed removed
g.s.d.a.SchemaDifference
$ScalarAddition
removed removed removed
g.s.d.a.SchemaDifference
$ScalarDeletion
removed removed removed
g.s.d.a.SchemaDifference
$ScalarModification
removed removed removed
g.s.d.a.SchemaDifference
$UnionAddition
removed removed removed
g.s.d.a.SchemaDifference
$UnionDeletion
removed removed removed
g.s.d.a.SchemaDifference
$UnionMemberAddition
removed removed removed
g.s.d.a.SchemaDifference
$UnionMemberDeletion
removed removed removed
g.s.d.a.SchemaDifference
$UnionModification
removed removed removed
g.s.d.DiffImpl removed removed removed
g.s.d.DiffImpl
$MappingEntry
removed removed removed
g.s.d.DiffImpl
$OptimalEdit
removed removed removed
g.s.d.Edge removed removed removed
g.s.d.EditOperation removed removed removed
g.s.d.EditOperation
$Operation
removed removed removed
g.s.d.EditorialCostForMapping removed removed removed
g.s.d.HungarianAlgorithm removed removed removed
g.s.d.Mapping removed removed removed
g.s.d.PossibleMappingsCalculator removed removed removed
g.s.d.PossibleMappingsCalculator
$1
removed removed removed
g.s.d.PossibleMappingsCalculator
$10
removed removed removed
g.s.d.PossibleMappingsCalculator
$11
removed removed removed
g.s.d.PossibleMappingsCalculator
$12
removed removed removed
g.s.d.PossibleMappingsCalculator
$13
removed removed removed
g.s.d.PossibleMappingsCalculator
$14
removed removed removed
g.s.d.PossibleMappingsCalculator
$15
removed removed removed
g.s.d.PossibleMappingsCalculator
$16
removed removed removed
g.s.d.PossibleMappingsCalculator
$17
removed removed removed
g.s.d.PossibleMappingsCalculator
$18
removed removed removed
g.s.d.PossibleMappingsCalculator
$19
removed removed removed
g.s.d.PossibleMappingsCalculator
$2
removed removed removed
g.s.d.PossibleMappingsCalculator
$20
removed removed removed
g.s.d.PossibleMappingsCalculator
$21
removed removed removed
g.s.d.PossibleMappingsCalculator
$22
removed removed removed
g.s.d.PossibleMappingsCalculator
$23
removed removed removed
g.s.d.PossibleMappingsCalculator
$24
removed removed removed
g.s.d.PossibleMappingsCalculator
$25
removed removed removed
g.s.d.PossibleMappingsCalculator
$26
removed removed removed
g.s.d.PossibleMappingsCalculator
$27
removed removed removed
g.s.d.PossibleMappingsCalculator
$28
removed removed removed
g.s.d.PossibleMappingsCalculator
$29
removed removed removed
g.s.d.PossibleMappingsCalculator
$3
removed removed removed
g.s.d.PossibleMappingsCalculator
$30
removed removed removed
g.s.d.PossibleMappingsCalculator
$31
removed removed removed
g.s.d.PossibleMappingsCalculator
$32
removed removed removed
g.s.d.PossibleMappingsCalculator
$33
removed removed removed
g.s.d.PossibleMappingsCalculator
$34
removed removed removed
g.s.d.PossibleMappingsCalculator
$35
removed removed removed
g.s.d.PossibleMappingsCalculator
$36
removed removed removed
g.s.d.PossibleMappingsCalculator
$37
removed removed removed
g.s.d.PossibleMappingsCalculator
$38
removed removed removed
g.s.d.PossibleMappingsCalculator
$39
removed removed removed
g.s.d.PossibleMappingsCalculator
$4
removed removed removed
g.s.d.PossibleMappingsCalculator
$40
removed removed removed
g.s.d.PossibleMappingsCalculator
$41
removed removed removed
g.s.d.PossibleMappingsCalculator
$42
removed removed removed
g.s.d.PossibleMappingsCalculator
$5
removed removed removed
g.s.d.PossibleMappingsCalculator
$6
removed removed removed
g.s.d.PossibleMappingsCalculator
$7
removed removed removed
g.s.d.PossibleMappingsCalculator
$8
removed removed removed
g.s.d.PossibleMappingsCalculator
$9
removed removed removed
g.s.d.PossibleMappingsCalculator
$PossibleMappings
removed removed removed
g.s.d.PossibleMappingsCalculator
$VertexContextSegment
removed removed removed
g.s.d.SchemaDiffing removed removed removed
g.s.d.SchemaDiffingCancelledException removed removed removed
g.s.d.SchemaDiffingRunningCheck removed removed removed
g.s.d.SchemaGraph removed removed removed
g.s.d.SchemaGraphFactory removed removed removed
g.s.d.SchemaGraphFactory
$1
removed removed removed
g.s.d.SchemaGraphFactory
$1IntrospectionNode
removed removed removed
g.s.d.Util removed removed removed
g.s.d.Vertex removed removed removed
g.s.d.Vertex
$VertexData
removed removed removed
g.u.CyclicSchemaAnalyzer removed removed removed
g.u.CyclicSchemaAnalyzer
$FindCyclesImpl
removed removed removed
g.u.CyclicSchemaAnalyzer
$GraphAndIndex
removed removed removed
g.u.CyclicSchemaAnalyzer
$SchemaCycle
removed removed removed

Full HTML report: build artifact jacoco-html-report

Updated: 2026-11-13 22:36:38 UTC

@andimarek
andimarek merged commit f64d443 into master Nov 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant