Skip to content

Remove parallel AST transformation and traversal - #4558

Merged
andimarek merged 1 commit into
masterfrom
codex/remove-parallel-traversal
Nov 13, 2026
Merged

andimarek merged 1 commit into
masterfrom
codex/remove-parallel-traversal

Conversation

@andimarek

@andimarek andimarek commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

This was an experimental traverser which was never used in production as far as we know.

If you relied on that, please reach out and we might consider adding it back or provide similar mechanism.

Remove parallel AST transformation and the unused parallel tree traverser. GraphQL Java's production callers already use serial traversal.

Delete the parallel implementations, context flag, mutation-helper branches, unused adapter context entries, and parallel-only tests. Retain all 23 serial AST transformation tests and the serial assertions in previously shared tests.

Breaking changes and migration

  • Remove both AstTransformer.transformParallel(...) overloads. Replace them with transform(root, visitor) and remove the ForkJoinPool argument. Visitor callbacks now run sequentially on the calling thread.
  • Remove TraverserContext.isParallel(). Remove calls and parallel-only visitor branches; custom context implementations should also remove the corresponding override.
  • TreeTransformer and SchemaTransformer no longer populate NodeAdapter.class in the traversal context. Visitors that need the adapter should retain an explicit reference.

Validation

  • 580 targeted Spock tests passed across traversal utilities, AST operations, query analysis, schema traversal, and schema transformation.
  • Javadoc built successfully.
  • Confirmed the removed classes and public methods are absent from compiled output.

@andimarek andimarek added the breaking change requires a new major version to be relased label Nov 13, 2026
@andimarek andimarek added this to the 27 milestone Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 17 6584 (-13 🔴) 6529 (-12 🔴) 0 (±0) 0 (±0) 55 (-1)
Java 21 6584 (-13 🔴) 6529 (-12 🔴) 0 (±0) 0 (±0) 55 (-1)
Java 25 6584 (-13 🔴) 6529 (-12 🔴) 0 (±0) 0 (±0) 55 (-1)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 19784 (-39 🔴) 19619 (-36 🔴) 0 (±0) 0 (±0) 165 (-3)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30469 2985 91.1% ±0.0%
Branches 9095 1476 86.0% ±0.0%
Methods 8140 1151 87.6% ±0.0%

Changed Class Coverage (6 classes)

Class Line Branch Method
g.l.AstTransformer
$2
removed removed removed
g.u.TreeParallelTransformer removed removed removed
g.u.TreeParallelTransformer
$EnterAction
removed removed removed
g.u.TreeParallelTraverser removed removed removed
g.u.TreeParallelTraverser
$1
removed removed removed
g.u.TreeParallelTraverser
$EnterAction
removed removed removed

Full HTML report: build artifact jacoco-html-report

Updated: 2026-11-13 22:29:01 UTC

@andimarek
andimarek merged commit 1798d60 into master Nov 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change requires a new major version to be relased

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant