Repository navigation
Remove parallel AST transformation and traversal - #4558
Merged
Merged
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (6 classes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an experimental traverser which was never used in production as far as we know.
If you relied on that, please reach out and we might consider adding it back or provide similar mechanism.
Remove parallel AST transformation and the unused parallel tree traverser. GraphQL Java's production callers already use serial traversal.
Delete the parallel implementations, context flag, mutation-helper branches, unused adapter context entries, and parallel-only tests. Retain all 23 serial AST transformation tests and the serial assertions in previously shared tests.
Breaking changes and migration
AstTransformer.transformParallel(...)overloads. Replace them withtransform(root, visitor)and remove theForkJoinPoolargument. Visitor callbacks now run sequentially on the calling thread.TraverserContext.isParallel(). Remove calls and parallel-only visitor branches; custom context implementations should also remove the corresponding override.TreeTransformerandSchemaTransformerno longer populateNodeAdapter.classin the traversal context. Visitors that need the adapter should retain an explicit reference.Validation