Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (10 classes)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nullable variable with a non-null default can legally be used in
@skip(if:)or@include(if:). Passing explicitnulloverrides that default and currently causes an uncaught null-unboxing exception:With
{"flag": null}and a nullableparent, this now returns{"good": ..., "parent": null}plus an error located at$flag, with path["parent"].ValuesResolver.getArgumentValues(), reusing the existingBoolean!coercion rules.data: null; nested failures preserve siblings and follow normal non-null propagation. Include the directive name, argument source location, and enclosing field path where applicable.Alternative to #4540: avoids an execution-wide
AbortExecutionException. Complements #4522, which handles field arguments before invoking data fetchers; conditional directives are evaluated during field collection.Validation: 57 new Spock cases cover queries, mutations, fragments, aliases, lists, async fetchers, subscriptions, defer, instrumentation, normalization, and all three DataLoader dispatch modes.
./gradlew --no-daemon test testng jacocoTestReport javadocpasses on Java 25 (6,352 cases, no failures). No per-class coverage regressions againsttest-baseline.json; the baseline is unchanged.