Repository navigation
Make FastBuilder type and directive order match the standard Builder - #4533
Merged
bbakerman merged 1 commit intoNov 4, 2026
Merged
Conversation
FastSchemaGenerator collected built types into a HashSet keyed on identity hash codes, and FastBuilder preserved insertion order, so getTypeMap() and getAdditionalTypes() order varied between JVM runs. Sort the type map by name like GraphQLTypeCollectingVisitor does, and place built-in directives first like Builder.ensureBuiltInDirectives.
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (1 class)
|
bbakerman
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed the ordering of the type map was not deterministic when using FastBuilder. Not a huge issue, but it makes some things simpler if ordering is stable, as the regular schema builder is.
While SDL printing is stable, we have several tests and other procedures that could be a little annoying to change in order.
Ordering the final type map should be cheap enough even for the fast builder, but let me know if you have any thoughts.