Repository navigation
Fix non-null union field implements nullable union interface field #4467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tonyghita
wants to merge
10
commits into
graphql-java:master
Choose a base branch
from
tonyghita:fix-interface-union-nullability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f6e7ca7
Fix non-null union field implements nullable union interface field
tonyghita 2e21d2a
Add test coverage for all nullabilty strengthening cases
tonyghita ed84963
Move unwrap non-null first so we're closer to spec
tonyghita cca8408
Merge branch 'master' into fix-interface-union-nullability
tonyghita 38e843e
Add test coverage for TypesImplementInterfaces branches
tonyghita 19c01c2
Merge branch 'master' into fix-interface-union-nullability
tonyghita 5ed8988
Merge branch 'master' into fix-interface-union-nullability
tonyghita 371322c
Merge branch 'master' into fix-interface-union-nullability
tonyghita 73583b8
Merge branch 'master' into fix-interface-union-nullability
tonyghita 081c438
Merge branch 'master' into fix-interface-union-nullability
bbakerman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra tests. More tests good!