Skip to content

Fix subscription alternative call context cleanup#4384

Merged
andimarek merged 1 commit into
masterfrom
fix-4314-subscription-call-context-cleanup
May 18, 2026
Merged

Fix subscription alternative call context cleanup#4384
andimarek merged 1 commit into
masterfrom
fix-4314-subscription-call-context-cleanup

Conversation

@andimarek

Copy link
Copy Markdown
Member

Summary

  • add a post-event data loader dispatch lifecycle callback to release subscription event call stacks after the event result completes
  • clean up alternative call context naming so it covers both deferred execution and subscription event execution
  • add regression coverage for per-level and exhausted dispatch strategies plus subscription integration coverage

Fixes #4314

Verification

  • ./gradlew test (5603 tests, 8 skipped)

Note: an initial non-clean full-suite run failed in JMHForkArchRuleTest due stale build output; after ./gradlew clean test --tests graphql.archunit.JMHForkArchRuleTest passed, a clean full ./gradlew test passed.

@andimarek andimarek enabled auto-merge (squash) May 18, 2026 22:19
@andimarek andimarek merged commit 5d914f1 into master May 18, 2026
11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5793 (+2 🟢) 5737 (+2 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5793 (+2 🟢) 5736 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5793 (+2 🟢) 5736 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5793 (+2 🟢) 5736 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23204 (+8 🟢) 22977 (+8 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29422 3102 90.5% ±0.0%
Branches 8611 1507 85.1% ±0.0%
Methods 7876 1209 86.7% ±0.0%

Changed Class Coverage (1 class)

Class Line Branch Method
g.e.SubscriptionExecutionStrategy +0.1% 🟢 ±0.0% ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-18 22:26:18 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak in graphql subscriptions

1 participant