Closed
Conversation
- ArrayValue/ObjectValue: inline assertNotNull(deepCopy(...)) to avoid @nullable local variable being passed where @nonnull is required - MergedField: replace assertNotNull on @nullable Builder field with explicit null check to satisfy stricter NullAway type inference Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andimarek
force-pushed
the
fix-nullaway-0.13.1
branch
from
169f27c to
dda29af
Compare
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (2 classes)
MergedField.Builder — method details
|
Member
Author
|
No longer needed — staying on NullAway 0.12.10 for now. See #4339. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayValue.deepCopy()/ObjectValue.deepCopy(): inlineassertNotNull(deepCopy(...))to avoid@Nullablelocal variable being passed where@NonNullis requiredMergedField.Builder.build(): replaceassertNotNullon@NullableBuilder field with explicit null checkTest plan
🤖 Generated with Claude Code