Skip to content

#419 - dynamic runtime wiring factory support - #420

Merged
bbakerman merged 3 commits into
graphql-java:masterfrom
bbakerman:419-dynamic-runtime-wiring-factory
May 18, 2017
Merged

bbakerman merged 3 commits into
graphql-java:masterfrom
bbakerman:419-dynamic-runtime-wiring-factory

Conversation

@bbakerman

Copy link
Copy Markdown
Member

No description provided.

@bbakerman
bbakerman requested a review from andimarek May 9, 2017 22:18
@bbakerman bbakerman added this to the 3.0.0 milestone May 9, 2017
@bbakerman

Copy link
Copy Markdown
Member Author

This could go into 4.x but its an extension of the IDL work that comes in 3.x

@andimarek

andimarek commented May 14, 2017 •

Copy link
Copy Markdown
Member

see #419

@andimarek

Copy link
Copy Markdown
Member

@bbakerman Interesting discussion about directives in the IDL and for example how to make directives accessible: graphql/graphql-js#746 (comment)

@andimarek
andimarek force-pushed the 419-dynamic-runtime-wiring-factory branch from af9889e to 4c1196b Compare May 18, 2017 09:32
@bbakerman

Copy link
Copy Markdown
Member Author

Interesting that Byron as proposed what we have done (nearly once we get schema gen to transfer the node def. which I meant to do but didnt)

...A simpler and more general solution would be to refer to the entire AST node associated with each definition when built with buildASTSchema. That would still allow access to directives for tooling (type.astNode.directives) but would also allow access to the rest of the AST

Comment thread src/main/java/graphql/Assert.java Outdated
throw new AssertException(errorMessage);
}

public static void assertNeverCalled() {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you make this
public static T assertNeverCalled()

then you can do this at call site

{
return assertShouldNeverBecalled()
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right ... will change it

@bbakerman

Copy link
Copy Markdown
Member Author

More than happy with the removal of the "smooshed" definition

@bbakerman
bbakerman merged commit 2a16238 into graphql-java:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants