Skip to content

Conversation

@yeikel
Copy link
Contributor

@yeikel yeikel commented Nov 16, 2025

Updates the CI and the build to use Java 25

Closes #4119

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build configuration and CI workflows to use Java 25 as the primary JDK, while adding Java 21 to the test matrix to ensure backward compatibility testing.

  • Updates GitHub Actions workflows to use JDK 25 instead of JDK 21
  • Adds a new testWithJava21 Gradle task to test backward compatibility with Java 21
  • Updates CI test matrices and test result paths to include Java 21 tests

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
build.gradle Adds testWithJava21 test task and makes it a dependency of the main test task
.github/workflows/release.yml Updates JDK version from 21 to 25 for release builds
.github/workflows/pull_request.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results
.github/workflows/master.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results

@reneleonhardt
Copy link

Has testWithJava25 specifically not been added?

@yeikel
Copy link
Contributor Author

yeikel commented Nov 17, 2025

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you update for the merge conflict?

@yeikel
Copy link
Contributor Author

yeikel commented Dec 7, 2025

Thanks for the PR. Could you update for the merge conflict?

It should be ready now. Thanks!

@reneleonhardt
Copy link

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}

@yeikel
Copy link
Contributor Author

yeikel commented Dec 9, 2025

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}

Thanks, I applied your feedback. See https://github.com/graphql-java/graphql-java/actions/runs/20075548260/job/57588814897?pr=4173#step:6:1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build and Test using Java 25

3 participants