-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Build and test using Java 25 #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the build configuration and CI workflows to use Java 25 as the primary JDK, while adding Java 21 to the test matrix to ensure backward compatibility testing.
- Updates GitHub Actions workflows to use JDK 25 instead of JDK 21
- Adds a new
testWithJava21Gradle task to test backward compatibility with Java 21 - Updates CI test matrices and test result paths to include Java 21 tests
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.gradle | Adds testWithJava21 test task and makes it a dependency of the main test task |
| .github/workflows/release.yml | Updates JDK version from 21 to 25 for release builds |
| .github/workflows/pull_request.yml | Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results |
| .github/workflows/master.yml | Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results |
|
Has |
Based on the previous pattern, my understanding of the build is that this will happen by default |
dondonz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Could you update for the merge conflict?
It should be ready now. Thanks! |
Could you log the actual JDK being tested just to be sure? test {
doFirst {
println "Running tests with JDK ${System.getProperty('java.version')}"
}
} |
Thanks, I applied your feedback. See https://github.com/graphql-java/graphql-java/actions/runs/20075548260/job/57588814897?pr=4173#step:6:1567 |
Updates the CI and the build to use Java 25
Closes #4119