Skip to content

#409 - Added interface checking on object types - #412

Merged
bbakerman merged 2 commits into
graphql-java:masterfrom
bbakerman:409-validate-interfaces-are-implemented
May 8, 2017
Merged

bbakerman merged 2 commits into
graphql-java:masterfrom
bbakerman:409-validate-interfaces-are-implemented

Conversation

@bbakerman

Copy link
Copy Markdown
Member

No description provided.

@bbakerman
bbakerman requested a review from andimarek May 7, 2017 11:16

@andimarek andimarek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two things to consider .... maybe the missing subscription case is an extra PR.

import graphql.schema.GraphQLFieldDefinition;
import graphql.schema.GraphQLType;

public interface ValidationRule {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename this to SchemaValidationRule or something similar ... ValidationRule too generic

});

traverse(schema.getQueryType(), rules, validationErrorCollector);
if (schema.isSupportingMutations()) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I think subscription is missing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is missing that. We can do that in another PR.

#414

@bbakerman
bbakerman merged commit 630a410 into graphql-java:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants