Repository navigation
#406 added extend type XXX {} support - #408
Merged
bbakerman merged 4 commits intoMay 7, 2017
Merged
Conversation
andimarek
requested changes
May 6, 2017
andimarek
left a comment
Member
There was a problem hiding this comment.
Great work ... just some minor clean code issues.
| })); | ||
|
|
||
| // combine all the fields together | ||
| for (GraphQLFieldDefinition fieldDefinition : fieldDefinitions.values()) { |
Member
There was a problem hiding this comment.
maybe also a forEach here to be consistent?
|
|
||
| typeDefinition.getFieldDefinitions().forEach(fieldDef -> | ||
| builder.field(buildField(buildCtx, typeDefinition, fieldDef))); | ||
| // |
Member
There was a problem hiding this comment.
This whole Method buildObjectType is too long imho. I suggest splitting it up into smaller parts.
| } | ||
|
|
||
| // | ||
| // interfaces |
Member
There was a problem hiding this comment.
I don't think such comments are very helpful: If you wanna document the following block I suggest extracting a method and name the method appropriately.
…upport-in-idl # Conflicts: # src/main/java/graphql/schema/idl/SchemaGenerator.java # src/test/groovy/readme/README.next.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#406 added extend type XXX {} support
this now allows the type extension syntax
This could be in multiple files say to modularize the schema files.
The schema grammar always had these...we just didnt apply them in the generator
I think this should be in 3.x because it fits the "add IDL support" them in 3.x