Skip to content

Fix IncrementalExecutionResult.transform() to preserve incremental fields #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Aug 11, 2025
Merged

Fix IncrementalExecutionResult.transform() to preserve incremental fields #4073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/graphql/incremental/IncrementalExecutionResultImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,13 @@ public static Builder fromExecutionResult(ExecutionResult executionResult) {
return new Builder().from(executionResult);
}

public static Builder fromIncrementalExecutionResult(IncrementalExecutionResult executionResult) {
return new Builder().from(executionResult);
}

@Override
public IncrementalExecutionResult transform(Consumer<ExecutionResult.Builder<?>> builderConsumer) {
var builder = fromExecutionResult(this);
var builder = fromIncrementalExecutionResult(this);
builderConsumer.accept(builder);
return builder.build();
}
Expand Down
11 changes: 10 additions & 1 deletion src/test/groovy/graphql/incremental/IncrementalExecutionResultTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,15 @@ class IncrementalExecutionResultTest extends Specification {

def "transform returns IncrementalExecutionResult"() {
when:
def initial = newIncrementalExecutionResult().hasNext(true).build()
def defer = newDeferredItem()
.label("homeWorldDefer")
.path(ResultPath.parse("/person"))
.data([homeWorld: "Tatooine"])
.build()
def initial = newIncrementalExecutionResult()
.hasNext(true)
.incremental([defer])
.build()

then:
def transformed = initial.transform { b ->
Expand All @@ -130,6 +138,7 @@ class IncrementalExecutionResultTest extends Specification {
}
transformed instanceof IncrementalExecutionResult
transformed.extensions == ["ext-key": "ext-value"]
transformed.incremental == initial.incremental
transformed.hasNext == false
}
}