Skip to content

simplify delayed dataloader dispatching by not using a batch window#4055

Merged
andimarek merged 2 commits intomasterfrom
simplify-delay-dataloader
Jul 24, 2025
Merged

simplify delayed dataloader dispatching by not using a batch window#4055
andimarek merged 2 commits intomasterfrom
simplify-delay-dataloader

Conversation

@andimarek
Copy link
Member

@andimarek andimarek commented Jul 23, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited
Loading

Test Results

  324 files   -    644    324 suites   - 644   3m 31s ⏱️ - 9m 9s
5 005 tests  -    348  4 999 ✅  -    349  6 💤 + 1  0 ❌ ±0 
5 094 runs   - 10 188  5 088 ✅  - 10 177  6 💤  - 11  0 ❌ ±0 

Results for commit 1dbd50e. ± Comparison against base commit e8028d9.

This pull request removes 562 and adds 190 tests. Note that renamed tests count towards both. 
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@d1a10ac delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@6fca2a8f delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@31fc71ab delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@7068f7ca delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@38548b19 delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@41aaedaa delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@1b32cd16 delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@5c20ffa8 delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@488b50ec delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@27b22f74 delegate=graphql.AssertTest@61d01788 owner=graphql.AssertTest@61d01788 thisObject=graphql.AssertTest@61d01788 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…
This pull request skips 1 test. 
graphql.schema.fetching.LambdaFetchingSupportTest ‑ different class loaders induce certain behaviours

♻️ This comment has been updated with latest results.

@dondonz dondonz added this to the 25.x breaking changes milestone Jul 24, 2025
dondonz
dondonz reviewed Jul 24, 2025
View reviewed changes
src/main/java/graphql/GraphQLUnusualConfiguration.java

import static graphql.Assert.assertNotNull;
import static graphql.execution.instrumentation.dataloader.DataLoaderDispatchingContextKeys.DELAYED_DATA_LOADER_BATCH_WINDOW_SIZE_NANO_SECONDS;
import static graphql.execution.instrumentation.dataloader.DataLoaderDispatchingContextKeys.DELAYED_DATA_LOADER_DISPATCHING_EXECUTOR_FACTORY;
Copy link
Member

@dondonz dondonz Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for me to remove this off the documentation then

@andimarek andimarek merged commit 378eb2b into master Jul 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dondonz dondonz dondonz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

2 participants

@andimarek @dondonz