Skip to content

Kaqqao 122 type resolver#395

Merged
bbakerman merged 6 commits into
graphql-java:masterfrom
bbakerman:kaqqao-122TypeResolver
May 1, 2017
Merged

Kaqqao 122 type resolver#395
bbakerman merged 6 commits into
graphql-java:masterfrom
bbakerman:kaqqao-122TypeResolver

Conversation

@bbakerman

@bbakerman bbakerman commented Apr 28, 2017

Copy link
Copy Markdown
Member

Merge branch '122TypeResolver' of git://github.com/kaqqao/graphql-java into kaqqao-122TypeResolver

Conflicts:
src/main/java/graphql/execution/ExecutionStrategy.java
src/test/groovy/graphql/RelaySchema.java
src/test/groovy/graphql/validation/SpecValidationSchema.java
src/test/groovy/graphql/validation/rules/Harness.java

This addresses #122 and #205.

We had clashing parameters in place. I fix this up and removed one set of them from the original PR

@kaqqao - this is a revamp of your PR

Bojan Tomic and others added 3 commits April 10, 2017 03:05
Merge branch '122TypeResolver' of git://github.com/kaqqao/graphql-java into kaqqao-122TypeResolver

# Conflicts:
#	src/main/java/graphql/execution/ExecutionStrategy.java
#	src/test/groovy/graphql/RelaySchema.java
#	src/test/groovy/graphql/validation/SpecValidationSchema.java
#	src/test/groovy/graphql/validation/rules/Harness.java

This addresses graphql-java#122 and graphql-java#205.

We had clashing parameters in place.  I fix this up and removed one set of them from the original PR
Damn you IDEA - you often miss changed files

Merge branch '122TypeResolver' of git://github.com/kaqqao/graphql-java into kaqqao-122TypeResolver

# Conflicts:
#	src/main/java/graphql/execution/ExecutionStrategy.java
#	src/test/groovy/graphql/RelaySchema.java
#	src/test/groovy/graphql/validation/SpecValidationSchema.java
#	src/test/groovy/graphql/validation/rules/Harness.java

This addresses graphql-java#122 and graphql-java#205.

We had clashing parameters in place.  I fix this up and removed one set of them from the original PR
@bbakerman

Copy link
Copy Markdown
Member Author

This is a re-implementation of #369

@bbakerman bbakerman added this to the 3.0.0 milestone Apr 30, 2017
bbakerman added 3 commits May 1, 2017 15:09
…olver

# Conflicts:
#	src/test/groovy/readme/ReadmeExamples.java
…olver

# Conflicts:
#	src/test/groovy/graphql/validation/SpecValidationSchema.java
@bbakerman bbakerman merged commit 5467441 into graphql-java:master May 1, 2017
@andimarek

Copy link
Copy Markdown
Member

@bbakerman @kaqqao This is a breaking change, right?
I remember some discussion using java 8 default implementations to avoid a breaking change, but I can't find it anymore.

Thanks!

@andimarek andimarek added the breaking change requires a new major version to be relased label May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change requires a new major version to be relased

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants