296 ast printer support#388
Merged
bbakerman merged 5 commits intoApr 30, 2017
Merged
Conversation
…upport # Conflicts: # src/main/java/graphql/introspection/Introspection.java
andimarek
requested changes
Apr 30, 2017
andimarek
left a comment
andimarek
left a comment
Member
There was a problem hiding this comment.
Great work again ... just one suggestion :-)
| * | Number | Int / Float | | ||
| * | Mixed | Enum Value | | ||
| */ | ||
| public static Value astFromValue(Object _value, GraphQLType type) { |
Member
There was a problem hiding this comment.
This method seems a bit messy overall: would you mind extracting methods for the specific types? (GraphQLNonNull, GraphQLList ...)
Member
Author
There was a problem hiding this comment.
sure - funny thing is its a direct port of the JS implementation. So its "reference mess" ;)
I agree its messy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked to fix #296 and realised that the project needs a AST printer in order to be able to fix it.
So thats what I added. Its based of the reference implementation.