Skip to content

Support for user defined subscription type - #358

Merged
andimarek merged 6 commits into
graphql-java:masterfrom
vaant:master
May 6, 2017
Merged

andimarek merged 6 commits into
graphql-java:masterfrom
vaant:master

Conversation

@vaant

@vaant vaant commented Apr 5, 2017

Copy link
Copy Markdown

Adding support for subscriptions with an implemenation to enable adding a user defined subscriptionType. Subscriptions can be thought of as mutations by a different name and with a different purpose and, as such, the implementation here is the same as that of mutations.

For more see: http://graphql.org/blog/subscriptions-in-graphql-and-relay/

…ng a user defined subscriptionType. Subscriptions can be thought of as mutations by a different name and with a different purpose and, as such, the implementation here is the same as that of mutations.

For more see: http://graphql.org/blog/subscriptions-in-graphql-and-relay/
@andimarek andimarek added this to the 3.0.0 milestone Apr 8, 2017
@andimarek

Copy link
Copy Markdown
Member

@vaant Thanks for this PR.

How does this PR relate to graphql/graphql-spec#267 ?

@kaqqao

kaqqao commented Apr 10, 2017

Copy link
Copy Markdown
Contributor

I must say I love the simplicity of this implementation.

@andimarek

Copy link
Copy Markdown
Member

@vaant Would you mind giving us the right to modify the PR (https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) ? We wanna add some documentation for example before we merge it.

@vaant

vaant commented May 1, 2017

Copy link
Copy Markdown
Author

@andimarek edits from maintainers should be allowed. As far as graphql#267, I would say this is a partial implementation. From my reading, there isn't anything that would preclude this as an initial implementation for the Subscription system but the corresponding Events system is entirely ignored. I suppose this limits usefulness, at least in regards to the RFC, but does provide a very simple way for users to set and manage their own SubscriptionType.

@andimarek

Copy link
Copy Markdown
Member

@vaant thanks a lot!

@andimarek andimarek self-assigned this May 2, 2017
@andimarek
andimarek merged commit 1b44b3e into graphql-java:master May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants