#268 - now follows spec in regard to null error handling#353
Merged
bbakerman merged 3 commits intoApr 16, 2017
Conversation
…-handling # Conflicts: # src/main/java/graphql/ErrorType.java # src/main/java/graphql/execution/Execution.java # src/test/groovy/graphql/GraphQLTest.groovy
Member
|
@bbakerman Could you update you PR? Thanks! |
…-handling # Conflicts: # src/main/java/graphql/execution/ExecutionStrategy.java # src/main/java/graphql/execution/ExecutorServiceExecutionStrategy.java # src/main/java/graphql/execution/SimpleExecutionStrategy.java # src/main/java/graphql/execution/batched/BatchedExecutionStrategy.java
Member
Author
|
base updated. Can I get a tick for this before I merge so the other dependent PRs can merege please namely #369 |
andimarek
approved these changes
Apr 13, 2017
andimarek
left a comment
andimarek
left a comment
Member
There was a problem hiding this comment.
Nice job! :-)
I am not totally happy about using Exceptions in this way to be honest ... did you thought about using a special ExecutionResult?
| return new Builder(); | ||
| } | ||
|
|
||
| private static GraphQLType unwrap(GraphQLType type) { |
Member
There was a problem hiding this comment.
This is also implemented in NoUnbrokenInputCycles .. .maybe we can make it dry?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#268 has problems with error handling re: http://facebook.github.io/graphql/#sec-Errors
This API breaking change fixes that. It now follows the rules on non null ness
The key change is a new "TypeInfo" object to track parent child types and their null ness.
The current type system cant do this (and probably should not).
The rules on making parent objects null have been followed