Skip to content

Removed deprecated methods in code registry #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 2 commits into from
Mar 26, 2024
Merged

Removed deprecated methods in code registry #3514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b9228
Removed deprecated methods in GraphQLCodeRegistry
bbakerman Mar 10, 2024
a7d4e94
Merge remote-tracking branch 'origin/master' into removed-deprecated-…
bbakerman Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions src/main/java/graphql/schema/GraphQLCodeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,6 @@ public GraphqlFieldVisibility getFieldVisibility() {
return fieldVisibility;
}

/**
* Returns a data fetcher associated with a field within a container type
*
* @param parentType the container type
* @param fieldDefinition the field definition
*
* @return the DataFetcher associated with this field. All fields have data fetchers
*
* @see #getDataFetcher(GraphQLObjectType, GraphQLFieldDefinition)
* @deprecated This is confusing because {@link GraphQLInterfaceType}s cant have data fetchers. At runtime only a {@link GraphQLObjectType}
* can be used to fetch a field. This method allows the mapping to be made, but it is never useful if an interface is passed in.
*/
@Deprecated(since = "2023-05-13")
public DataFetcher<?> getDataFetcher(GraphQLFieldsContainer parentType, GraphQLFieldDefinition fieldDefinition) {
return getDataFetcherImpl(FieldCoordinates.coordinates(parentType, fieldDefinition), fieldDefinition, dataFetcherMap, systemDataFetcherMap, defaultDataFetcherFactory);
}

/**
* Returns a data fetcher associated with a field within an object type
*
Expand Down Expand Up @@ -252,23 +235,6 @@ private Builder markChanged(boolean condition) {
return this;
}

/**
* Returns a data fetcher associated with a field within a container type
*
* @param parentType the container type
* @param fieldDefinition the field definition
*
* @return the DataFetcher associated with this field. All fields have data fetchers
*
* @see #getDataFetcher(GraphQLObjectType, GraphQLFieldDefinition)
* @deprecated This is confusing because {@link GraphQLInterfaceType}s cant have data fetchers. At runtime only a {@link GraphQLObjectType}
* can be used to fetch a field. This method allows the mapping to be made, but it is never useful if an interface is passed in.
*/
@Deprecated(since = "2023-05-13")
public DataFetcher<?> getDataFetcher(GraphQLFieldsContainer parentType, GraphQLFieldDefinition fieldDefinition) {
return getDataFetcherImpl(FieldCoordinates.coordinates(parentType, fieldDefinition), fieldDefinition, dataFetcherMap, systemDataFetcherMap, defaultDataFetcherFactory);
}

/**
* Returns a data fetcher associated with a field within an object type
*
Expand Down Expand Up @@ -357,24 +323,6 @@ public Builder dataFetcher(FieldCoordinates coordinates, DataFetcher<?> dataFetc
return dataFetcher(assertNotNull(coordinates), DataFetcherFactories.useDataFetcher(dataFetcher));
}

/**
* Sets the data fetcher for a specific field inside a container type
*
* @param parentType the container type
* @param fieldDefinition the field definition
* @param dataFetcher the data fetcher code for that field
*
* @return this builder
*
* @see #dataFetcher(GraphQLObjectType, GraphQLFieldDefinition, DataFetcher)
* @deprecated This is confusing because {@link GraphQLInterfaceType}s cant have data fetchers. At runtime only a {@link GraphQLObjectType}
* can be used to fetch a field. This method allows the mapping to be made, but it is never useful if an interface is passed in.
*/
@Deprecated(since = "2023-05-13")
public Builder dataFetcher(GraphQLFieldsContainer parentType, GraphQLFieldDefinition fieldDefinition, DataFetcher<?> dataFetcher) {
return dataFetcher(FieldCoordinates.coordinates(parentType.getName(), fieldDefinition.getName()), dataFetcher);
}

/**
* Sets the data fetcher for a specific field inside an object type
*
Expand Down